Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate dolt cherry-pick to only use SQL #6259

Merged
merged 23 commits into from
Jul 7, 2023
Merged

Conversation

PavelSafronov
Copy link
Contributor

@PavelSafronov PavelSafronov commented Jun 29, 2023

This change migrates dolt cherry-pick to only use SQL.

Related: #3922

@macneale4 macneale4 self-requested a review June 29, 2023 19:55
# Conflicts:
#	integration-tests/bats/sql-local-remote.bats
# Conflicts:
#	go/cmd/dolt/commands/status.go
#	integration-tests/bats/sql-local-remote.bats
@macneale4 macneale4 self-requested a review July 7, 2023 16:17
Copy link
Contributor

@macneale4 macneale4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. One println which I think needs to be removed, and a comment about a comment. When tests pass let 'er rip.

@PavelSafronov PavelSafronov merged commit 49edd91 into main Jul 7, 2023
@PavelSafronov PavelSafronov deleted the pavel/dolt-cherry-pick branch July 7, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants